Oracle connector enhancements

[Dilli-Babu-Godari]

Description

Oracle connector enhancements.

Motivation and Context

Impact

Test Plan

Contributor checklist

• [ ] Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• [ ] If release notes are required, they follow the release notes guidelines.
• [ ] Adequate tests were added if applicable.
• [ ] CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
*  Oracle connector enhancements in WxD :pr: 25355

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: Dilli-Babu-Godari / name: Dilli-Babu-Godari (8b01134e996ad4487b7248a21a42291c242234c6, e312fcc7fff0948f6679dbd46a852f2347e8861f, 8d8e7df4b213b81583bc76b1f9d61b50ebce887c)

[steveburnett]

Thanks for the release note entry!

• The PR is now automatically included, you don't have to add it in yourself anymore.
• Revise the entry to begin with a word from the Order of changes in the Release Notes Guidelines: is the work in this PR a Fix, for example?
• Expand the abbreviation WxD.
• Should the section be Oracle Connector Changes instead of General Changes?

[prestodb-ci]

@ethanyzhang imported this issue as lakehouse/presto #25355

[Dilli-Babu-Godari]

I have a few comments -

1. Let's split PR in 2 commits - TLS & fetchsize changes
2. I think TLS is going to be a generic feature acorss different JDBC connectors, maybe we can create a separate TLS config or have it in BaseJDBC config and reuse it in the required JDBC connector?

This PR currently includes 4 combined PR changes. I can split them into 2 separate PRs as you suggested.

[Dilli-Babu-Godari]

Thanks for the release note entry!

• The PR is now automatically included, you don't have to add it in yourself anymore.
• Revise the entry to begin with a word from the Order of changes in the Release Notes Guidelines: is the work in this PR a Fix, for example?
• Expand the abbreviation WxD.
• Should the section be Oracle Connector Changes instead of General Changes?

Updated the changes

[steveburnett]

Updated the changes

Thanks for addressing the last point! Please address these:

• The PR is now automatically included, you don't have to add it in yourself anymore.
• Revise the entry to begin with a word from the Order of changes in the Release Notes Guidelines: is the work in this PR a Fix, for example?
• Expand the abbreviation WxD.

[Dilli-Babu-Godari]

Updated the changes

Thanks for addressing the last point! Please address these:

• The PR is now automatically included, you don't have to add it in yourself anymore.
• Revise the entry to begin with a word from the Order of changes in the Release Notes Guidelines: is the work in this PR a Fix, for example?
• Expand the abbreviation WxD.

Updated the changes.

[steveburnett]

Formatting nits and suggestions for the release note:

== RELEASE NOTES ==

Oracle Connector Changes
*  Add oraorai18n.jar dependency and SSL config for Oracle connector.

[Dilli-Babu-Godari]

Formatting nits and suggestions for the release note:

== RELEASE NOTES ==

Oracle Connector Changes
*  Add oraorai18n.jar dependency and SSL config for Oracle connector.

Updated changes.

[Dilli-Babu-Godari]

I think we should have one more flag -oracle.tls.enabled and then based on that add it to config. Also what testing is done for this? I don't see any tests cases as well?

I have added test cases and oracle.tls.enabled flag in config. Logged the fields manually after running queries in local.

[Dilli-Babu-Godari]

I don't see any usage of isTlsEnabled? Also commit config tests in existing resptective commits, it doesn;t require a separate commit

Changes done, please let me know if anything else is needed.

[agrawalreetika]

Please add test cases for your PR as well, once Oracle tests are enabled.