prestodb
document null vs nan
Fixes #16739
This clarifies in the docs that NaN and NULL are different.
I'm not sure whether the text should say nan() or NaN.
- :x: - Matthew Davis The commit (3e7b5e85f082c526bb05313b80e5ccfca2eeee60) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Oh this is one of those projects that require a Linux Foundation CLA. Ok, it's going to take me a while to get that signed. (More effort than it took to write the PR.)
Ok, CLA signed. How do I re-trigger the CI bot to run the usual workflow tests?
Apparently the bots want me to sign two CLAs. Corporate and individual. This is getting ridiculous.
And how do I retrigger the CLA CI bot now, to let me through?
Sorry @mdavis-xyz for the confusion. @aweisberg do you think you can help here?
The CLA bot only checks that the CLA has been signed when the PR changes. If you force push it will recheck. I can do that for you.
It's still not approving. What email and github ID did you use when signing the CLA? The email on the commit has to be linked to the GH accounted you signed the CLA with so the bot can verify the commit is from that GH account.
The CLA process is managed by the LF/EasyCLA and it's completely self service so unfortunately I can't actively debug it I can only tell you how it works :-)
If you did the corporate CLA thing it's worth verifying that the corporate CLA actually has your GH account in it. I have had the web UI fail to save changes before.
I can't figure it out.
I've whitelisted my github user, and email address. I've rewritten the commit username to be my work email address. Still it doesn't recognise me. I am a CLA manager for my org, so I can see the org settings for this repo.
The link to raise a support ticket with LF doesn't work. That login page for their Jira just redirects me back to the login page after I've logged in.
There seem to be two github accounts in play here? mdavis-xyz is the one you are commenting with and the commit is attributed to matt-telstra. Is there any possibility that this is contributing to the mix up?
It was initially all mdavis-xyz, and I whitelisted that username in my org's CLF settings. But that didn't work. So I amended the commits to use my work email address instead of my normal email address for github, which github now recognises as my other github user. Both email addresses and both github usernames are whitelisted in my org's settings.
I just tried creating PR #16980, which is identical in content, but the PR creator and commit author are both the other one (matt-telstra). Still I'm getting the same error.
So unfortunately I don't have any tools to help debug this. I don't think there is any sort of admin panel for anyone on the project.
What the CLA bot is looking for as far as I can tell is a github account linked to the email on the commit that has signed the CLA. It only notices when you have signed after you update the PR and it rechecks. The only other trick is it pops up a box telling you to click through the UI and accept as an individual or something after you have been added to the allow list for your company.
I don't actually go through the process myself, so I don't know what the exact steps look like, but once you get through them it really does work.
I will say I have had instances where I added people for the company CLA and then they disappeared from the UI on reload. Retrying eventually worked.
Ah woops, I got confused after the holiday.
I'll close this, replaced by #16980
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions!
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Closing this PR because it's a duplicate of #16980. Although that one is still stuck because of CLA issues.