signals icon indicating copy to clipboard operation
signals copied to clipboard

Cleanup useComputed's on unmount

Open developit opened this issue 3 years ago • 3 comments

Need to duplicate this in the React version.

developit avatar Sep 09 '22 18:09 developit

⚠️ No Changeset found

Latest commit: 4ff4eb7738d9207ed8909058f857a3e820ebf556

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 09 '22 18:09 changeset-bot[bot]

Deploy Preview for preact-signals-demo ready!

Name Link
Latest commit 4ff4eb7738d9207ed8909058f857a3e820ebf556
Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/631b8d21c482d700086aa651
Deploy Preview https://deploy-preview-113--preact-signals-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 09 '22 18:09 netlify[bot]

Size Change: -767 B (-1%)

Total Size: 59 kB

Filename Size Change
docs/dist/assets/index.********.js 233 B -830 B (-78%) 🏆
docs/dist/assets/signals.module.********.js 5.68 kB +15 B (0%)
packages/preact/dist/signals.js 1.16 kB +25 B (+2%)
packages/preact/dist/signals.mjs 1.14 kB +23 B (+2%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/basic.********.js 217 B
docs/dist/assets/client.********.js 45.8 kB
docs/dist/assets/signals-core.module.********.js 870 B
docs/dist/assets/style.********.css 585 B
packages/core/dist/signals-core.js 1 kB
packages/core/dist/signals-core.mjs 829 B
packages/react/dist/signals.js 798 B
packages/react/dist/signals.mjs 753 B

compressed-size-action

github-actions[bot] avatar Sep 09 '22 19:09 github-actions[bot]

I believe this can be closed. Computeds don't need to be explicitly disposed anymore since @preact/signals-core v1.2.0.

jviide avatar Mar 28 '24 15:03 jviide

Closing it based on @jviide's comment

JoviDeCroock avatar Mar 28 '24 15:03 JoviDeCroock