preact icon indicating copy to clipboard operation
preact copied to clipboard

fix: `_listeners` mangle to reduce collisions

Open rschristian opened this issue 1 year ago • 2 comments

Closes #4461, unless anyone thinks we can get away with this in a minor?

Somewhat related: looks like 10.11 was skipped in the "backport" to v11 hence why we're missing $_listeners in mangle.json (and a few other things, such as useId)

rschristian avatar Jul 31 '24 05:07 rschristian

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: 77.06ms - 78.86ms
  • 03_update10th1k_x16: 31.00ms - 32.45ms
  • 07_create10k: 859.74ms - 879.46ms
  • filter_list: 124.47ms - 128.62ms
  • hydrate1k: 61.30ms - 63.64ms
  • many_updates: 111.14ms - 114.02ms
  • text_update: 34.98ms - 36.22ms
  • todo: 19.21ms - 19.35ms

usedJSHeapSize

  • 02_replace1k: 3.49ms - 3.49ms
  • 03_update10th1k_x16: 3.36ms - 3.36ms
  • 07_create10k: 25.01ms - 25.04ms
  • filter_list: 1.63ms - 1.63ms
  • hydrate1k: 9.22ms - 10.00ms
  • many_updates: 4.77ms - 4.77ms
  • text_update: 0.90ms - 0.90ms
  • todo: 0.92ms - 0.92ms

Results

02_replace1k
  • Browser: chrome-headless 126.0.6478.182
  • Sample size: 50
  • Built by: Benchmarks #1628
  • Commit: 9ea6c7d

duration

VersionAvg timevs
77.06ms - 78.86ms-

usedJSHeapSize

VersionAvg timevs
3.49ms - 3.49ms-

run-warmup-0

VersionAvg timevs
26.55ms - 27.48ms-

run-warmup-1

VersionAvg timevs
28.71ms - 30.11ms-

run-warmup-2

VersionAvg timevs
31.60ms - 32.64ms-

run-final

VersionAvg timevs
77.08ms - 78.88ms-
03_update10th1k_x16
  • Browser: chrome-headless 126.0.6478.182
  • Sample size: 50
  • Built by: Benchmarks #1628
  • Commit: 9ea6c7d

duration

VersionAvg timevs
31.00ms - 32.45ms-

usedJSHeapSize

VersionAvg timevs
3.36ms - 3.36ms-
07_create10k
  • Browser: chrome-headless 126.0.6478.182
  • Sample size: 50
  • Built by: Benchmarks #1628
  • Commit: 9ea6c7d

duration

VersionAvg timevs
859.74ms - 879.46ms-

usedJSHeapSize

VersionAvg timevs
25.01ms - 25.04ms-
filter_list
  • Browser: chrome-headless 126.0.6478.182
  • Sample size: 50
  • Built by: Benchmarks #1628
  • Commit: 9ea6c7d

duration

VersionAvg timevs
124.47ms - 128.62ms-

usedJSHeapSize

VersionAvg timevs
1.63ms - 1.63ms-
hydrate1k
  • Browser: chrome-headless 126.0.6478.182
  • Sample size: 50
  • Built by: Benchmarks #1628
  • Commit: 9ea6c7d

duration

VersionAvg timevs
61.30ms - 63.64ms-

usedJSHeapSize

VersionAvg timevs
9.22ms - 10.00ms-
many_updates
  • Browser: chrome-headless 126.0.6478.182
  • Sample size: 50
  • Built by: Benchmarks #1628
  • Commit: 9ea6c7d

duration

VersionAvg timevs
111.14ms - 114.02ms-

usedJSHeapSize

VersionAvg timevs
4.77ms - 4.77ms-
text_update
  • Browser: chrome-headless 126.0.6478.182
  • Sample size: 50
  • Built by: Benchmarks #1628
  • Commit: 9ea6c7d

duration

VersionAvg timevs
34.98ms - 36.22ms-

usedJSHeapSize

VersionAvg timevs
0.90ms - 0.90ms-
todo
  • Browser: chrome-headless 126.0.6478.182
  • Sample size: 50
  • Built by: Benchmarks #1628
  • Commit: 9ea6c7d

duration

VersionAvg timevs
19.21ms - 19.35ms-

usedJSHeapSize

VersionAvg timevs
0.92ms - 0.92ms-

tachometer-reporter-action v2 for Benchmarks

github-actions[bot] avatar Jul 31 '24 05:07 github-actions[bot]

Coverage Status

coverage: 99.19%. remained the same when pulling 9ea6c7d5e926f67df168e696388f8487f33953bd on fix/listeners-mangle into a1f6a43444dc069fe31b22e1a8b54ee090ee7758 on v11.

coveralls avatar Jul 31 '24 05:07 coveralls