preact icon indicating copy to clipboard operation
preact copied to clipboard

Published 20 hours ago • verified publisher icon preactjs

fix demo build

Open gengjiawen opened this issue 1 year ago • 3 comments

fix https://github.com/preactjs/preact/issues/4457

cc @marvinhagemeister

gengjiawen avatar Jul 27 '24 10:07 gengjiawen

Coverage Status

coverage: 99.485% (-0.001%) from 99.486% when pulling 4d1461eb4466aeaf08303797fe5a3a47a414eac6 on gengjiawen:fix/demo into 93515884b97af35a5b5b4ced1a8deb52caeb1a40 on preactjs:main.

coveralls avatar Jul 27 '24 11:07 coveralls

Yeah unfortunately there's a circular reference there that Vite can't work out from the source files, will need to use the built.

rschristian avatar Jul 27 '24 11:07 rschristian

Yeah unfortunately there's a circular reference there that Vite can't work out from the source files, will need to use the built.

looks fixable via a hack.

gengjiawen avatar Jul 27 '24 11:07 gengjiawen

Fixed in #4551, thank you for starting this 🙌

JoviDeCroock avatar Nov 11 '24 07:11 JoviDeCroock

Fixed in #4551, thank you for starting this 🙌

Thx for doing this. A co-author would be perfect in your new commit :)

gengjiawen avatar Nov 11 '24 07:11 gengjiawen