preact icon indicating copy to clipboard operation
preact copied to clipboard

Update props.js

Open developit opened this issue 5 years ago • 4 comments

developit avatar Apr 13 '20 01:04 developit

Size Change: +32 B (0%)

Total Size: 39.1 kB

Filename Size Change
dist/preact.js 3.8 kB +8 B (0%)
dist/preact.min.js 3.8 kB +8 B (0%)
dist/preact.module.js 3.82 kB +7 B (0%)
dist/preact.umd.js 3.87 kB +9 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.12 kB 0 B
compat/dist/compat.module.js 3.14 kB 0 B
compat/dist/compat.umd.js 3.17 kB 0 B
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 175 B 0 B
devtools/dist/devtools.module.js 185 B 0 B
devtools/dist/devtools.umd.js 252 B 0 B
hooks/dist/hooks.js 1.05 kB 0 B
hooks/dist/hooks.module.js 1.08 kB 0 B
hooks/dist/hooks.umd.js 1.12 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

github-actions[bot] avatar Apr 13 '20 01:04 github-actions[bot]

Coverage Status

Coverage remained the same at 99.8% when pulling 88e119e71bf1e7823f4425841da3c3b5554e231e on aria-golf-test into 3426ec572ca465fbe959692625dacdffab75e2a5 on master.

github-actions[bot] avatar Apr 13 '20 01:04 github-actions[bot]

@developit A sentence about the reason for the change would be awesome :+1: Is it performance? A bug you encountered somewhere? :upside_down_face:

marvinhagemeister avatar Apr 13 '20 16:04 marvinhagemeister

Ah nah - I was just guessing this would be smaller and wasn't near a computer so I abused the size bot to check.

There is probably a decent performance advantage to this check, but it's also a looser check and maybe not worthwhile.

developit avatar Apr 13 '20 17:04 developit