preact-router icon indicating copy to clipboard operation
preact-router copied to clipboard

Published 20 hours ago • verified publisher icon preactjs

feat: preventBubbling is optional

Open apostololeg opened this issue 6 years ago • 1 comments
trafficstars

Hi there! I moved from react to preact and detect that my autoClose-feature in Popup was broken. I discover that preact-router are preventing event bubbling when clicking on <Link/>. I wonder to ask you – what prompted you to do this❓🙂

Anyway, I made this PR in case if you(like me) will decide to move this feature from default to optional.

apostololeg avatar Sep 23 '19 21:09 apostololeg

Hi @apostololeg! I think we could actually just remove the bubbling prevention. preact-router is only replacing the default behavior, so it should really only be preventing default, not bubbling.

Want to update this PR?

developit avatar Oct 18 '19 16:10 developit