preact-cli icon indicating copy to clipboard operation
preact-cli copied to clipboard

refactor: Simplify CLI flag validation

Open rschristian opened this issue 3 years ago • 1 comments
trafficstars

What kind of change does this PR introduce?

Refactor

Did you add tests for your changes?

Adjusted one, yes.

Larger test changes were extracted to #1738 because this diff was rather large and I wanted to use base other work off of both of these independently.

Summary

Partial revert of #1467

sade has a builtin mechanism for catching unknown options being passed to it, allowing us to simplify things a bit.

There should be no functional changes here at all.

Does this PR introduce a breaking change?

No

rschristian avatar Jun 07 '22 08:06 rschristian

⚠️ No Changeset found

Latest commit: 7b6b0077ee557d1a05fb6e887ad321ca239edd0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 07 '22 08:06 changeset-bot[bot]