preact-cli icon indicating copy to clipboard operation
preact-cli copied to clipboard

Output all immutable files into common directory

Open teodragovic opened this issue 5 years ago • 2 comments

Do you want to request a feature or report a bug?

Feature

What is the current behaviour?

All webpack-generated files are outputted into build directory alongside files from static, index.html and manifest.json that are copied verbatim.

If this is a feature request, what is motivation or use case for changing the behaviour?

CRA has heuristic that all hash-based, immutable files are placed in static/ directory. Generated files that should not be cached like sw are NOT part of this directory. This makes writing server caching rules easier.

IMO it would be great if the same or similar setup could be provided by preact-cli.

teodragovic avatar Aug 04 '20 09:08 teodragovic

I've also just run into this problem, deploying to Vercel and trying to set cache headers for immutable files, but they're not colocated so have had to resort to some funky regexing.

benkingcode avatar Aug 04 '20 18:08 benkingcode

FYI this is the current caching solution my team uses:

ALL files have Cache-Control: max-age=0, must-revalidate, public header set along with ETag and Last Modified. This makes sure files are cached but always re-validated against origin server before use.

Reference: https://www.netlify.com/blog/2017/02/23/better-living-through-caching/

teodragovic avatar Aug 12 '20 08:08 teodragovic