eslint-config-preact icon indicating copy to clipboard operation
eslint-config-preact copied to clipboard

Support for ESLint v9?

Open jasonhilldm opened this issue 1 year ago • 7 comments

I tried to use ESLint v9.3.0 and got the following error:

Could not resolve dependency: peer eslint@"6.x || 7.x || 8.x" from [email protected]

Are there any plans to support v9?

jasonhilldm avatar May 19 '24 09:05 jasonhilldm

PRs certainly welcome.

I think this is a pretty low-priority repo for us and eslint v9 might not be supported w/out community contribution.

Edit: You might be able to get away with skipping strict peer deps

rschristian avatar May 19 '24 10:05 rschristian

Looks like eslint v9 support might depend on eslint v9 support in the following dependencies:

Dependency Status Link
eslint-plugin-compat ⛔ Not supported yet https://github.com/amilajack/eslint-plugin-compat/issues/614
eslint-plugin-jest ⚒️ Supported from v28 https://github.com/jest-community/eslint-plugin-jest/releases/tag/v28.0.0
eslint-plugin-react ⛔ Not supported yet https://github.com/jsx-eslint/eslint-plugin-react/issues/3699
eslint-plugin-react-hooks ⛔ Updated, pending release https://github.com/facebook/react/pull/28773#issuecomment-2085562863

watsonarw avatar May 21 '24 14:05 watsonarw

All of the peer dependencies shown above have been updated to support eslint v9. Do we know of any additional changes required for this plugin to support v9?

mhamann avatar Aug 27 '24 19:08 mhamann

eslint-plugin-react-hooks is not yet released in stable :(

see: https://github.com/facebook/react/pull/28773#issuecomment-2305862875

euskadi31 avatar Sep 06 '24 11:09 euskadi31

maybe release a rc too which requires a rc of eslint-plugin-react-hooks? This blocks our eslint update since months and we don't even use hooks ;-)

hbroer avatar Sep 30 '24 12:09 hbroer

at least an RC is available now https://github.com/facebook/react/pull/28773#issuecomment-2384093379

rburgst avatar Oct 01 '24 10:10 rburgst

Just saw this on Twitter: https://github.com/facebook/react/releases/tag/eslint-plugin-react-hooks%405.0.0

Does this mean we're good to go here? Sorry, not an eslint user myself, have to rely a bit on others giving a yay/nay.

rschristian avatar Oct 11 '24 21:10 rschristian

Eslint-plugin-react-hooks now supports v9 as is released: https://github.com/facebook/react/pull/28773#issuecomment-2417522136

So all points from watsonarw should be adressed.

Looks like eslint v9 support might depend on eslint v9 support in the following dependencies: Dependency Status Link eslint-plugin-compat ⛔ Not supported yet amilajack/eslint-plugin-compat#614 eslint-plugin-jest ⚒️ Supported from v28 https://github.com/jest-community/eslint-plugin-jest/releases/tag/v28.0.0 eslint-plugin-react ⛔ Not supported yet jsx-eslint/eslint-plugin-react#3699 eslint-plugin-react-hooks ⛔ Updated, pending release facebook/react#28773 (comment)

JonasKellerer avatar Dec 12 '24 13:12 JonasKellerer

@watsonarw any other concerns with upgrading to ESLint v9?

brianrodri avatar Jan 02 '25 17:01 brianrodri

Supporting v9 would be really great

EDIT : ended up with eslint-plugin-react and copying the rules from this repo's index.js

dolie avatar Feb 12 '25 14:02 dolie

🆙

z0mt3c avatar Feb 19 '25 08:02 z0mt3c

Released in 2.0.0

JoviDeCroock avatar Jul 12 '25 11:07 JoviDeCroock