compressed-size-action icon indicating copy to clipboard operation
compressed-size-action copied to clipboard

Published 20 hours ago • verified publisher icon preactjs

Comments are not stripped from compressed files

Open necolas opened this issue 5 years ago • 3 comments

JavaScript comments are not removed from the built files and contribute to reported file size. I think comments should be stripped to provide realistic data that reflects what a production build would do.

necolas avatar Aug 28 '20 19:08 necolas

I opened an issue against the size-plugin-core module as it looks like that is where the feature is missing - https://github.com/kuldeepkeshwar/size-plugin-core/issues/8

necolas avatar Aug 28 '20 20:08 necolas

This would likely have to be an option that is disabled by default, since it requires parsing the JS. That'll be slow, right now file files aren't even loaded into memory.

developit avatar Dec 18 '20 16:12 developit

FWIW I use a fork of this action with a fork of the size plugin - https://github.com/necolas/compressed-size-plugin/commit/082eb2c4cb56548aedfa6e967aa52507e569ccad

necolas avatar Dec 18 '20 18:12 necolas