compressed-size-action icon indicating copy to clipboard operation
compressed-size-action copied to clipboard

Better support for monorepos

Open Meemaw opened this issue 5 years ago • 2 comments

In a monorepo one might use multiple actions on a PR to report changes on different modules.

  • If using comments, each of those actions will override/"update" the previous comment.
  • If using "use-check" the behaviour is wrong as well

Proposed solution:

  • Introduce an input that will dedup those comments (e.g. label or something). One could pass label="App 1", label="App2" (this could also be displayed in the final markdown for better UI/UX) which would additionally be used to dedup the comments.

Meemaw avatar Aug 26 '20 11:08 Meemaw

Wouldn't it be better to have a single action calculate and size diffs for all files in the monorepo?

developit avatar Dec 18 '20 16:12 developit

Agreed with @developit, if you use Lerna, for example, you just have to include all packages using pattern

          pattern: './packages/*/dist/*.{js,css}'

frassinier avatar Feb 11 '21 21:02 frassinier