dmarc-report-processor icon indicating copy to clipboard operation
dmarc-report-processor copied to clipboard

Published 20 hours ago • verified publisher icon prbinu

Extend output

Open vquie opened this issue 7 years ago • 4 comments

Add report_id to output.

vquie avatar Dec 20 '17 11:12 vquie

Hi, Thanks for the PR, and sorry for late response.

The output is a KV pair, separated by ','. So wondering why do we need to put quotes around org name.

prbinu avatar Jan 03 '18 03:01 prbinu

We recently transitioned to primarily exporting JSON to address multiple issues we found in our KV extractions, which would also address any issues with fields that contain commas inappropriately

malvidin avatar Jan 09 '18 11:01 malvidin

For example, records that contain multiple DKIM results

malvidin avatar Jan 09 '18 11:01 malvidin

The script is filtering ',' chars from the value. Is this not sufficient:

org_name = (elem.findtext("org_name", 'NULL')).translate(None, ',')

Ref: https://github.com/vquiering/dmarc-report-processor/blob/c91c878190faa9e6c28730a4a56332a94e7c3f11/bin/dmarc-parser.py#L36

prbinu avatar Jan 10 '18 05:01 prbinu