react-diff-viewer icon indicating copy to clipboard operation
react-diff-viewer copied to clipboard

fix: for issue-144 page hanging on large files

Open TristanSpeakEasy opened this issue 3 years ago • 2 comments
trafficstars

fix for https://github.com/praneshr/react-diff-viewer/issues/144

TristanSpeakEasy avatar Sep 30 '22 10:09 TristanSpeakEasy

pls merge this, most wanted for me

kamaldlk avatar Oct 21 '22 11:10 kamaldlk

This code should not be used. It is faster, but it is incorrect.

Because the new approach is "chunking" the diff processing into sets of 100 it gives incorrect results on inputs over 100 lines long. For example, you can use the following inputs to simulate a pair of input files 302 lines long where the only difference is that a single line has been removed from the new value.

const range = (start, end) => [...Array(end).keys()].slice(start, end);
const oldValue = `{\n${range(0, 300).join('\n')}\n}`;
const newValue = `{\n${[...range(0, 50), ...range(51, 300)].join('\n')}\n}`;

When I try this in the original version of the code it works fine, and reports only the line containing "50" as removed and no other changes. When I try it with the suggested change above it correctly reports the line containing "50" as removed on the left, but then reports the lines containing "99", "149", "199", "249", and "299" as removed on the left and added on the right.

This problem will become worse the larger the difference in line counts between the files. Once you get past 100 lines difference on a given side, every line will be reported as a difference even when all the lines exist with no changes elsewhere in each file.

erothmayer avatar Oct 23 '22 14:10 erothmayer