Pascal Querner

Results 106 comments of Pascal Querner

Images can use the `backend_model` `Mage_Adminhtml_Model_System_Config_Backend_Image`, this will allow uploading of `'jpg', 'jpeg', 'gif', 'png'` already. No need to have that in the base class. As for the path I...

@ADDISON74 its unclear which PHP version you were running or if you did use the upgrade path (or started with a fresh 20.5.0). @hansgv Can you add your database information?...

I'd argue overwrite that class to have your wanted behaviour.

Other clients may parse the empty location string and now its not there. Or its stripped before sending out (nginx). Tons of different reasons not to touch it here. A...

I still think this is a heavy change for no benefits. 302 empty Location could mean "redirect to self". Now we take it away with no benefit. Why cant your...

> @pquerner I don't know how to response with 200 on POST without redirection. If you would show me the way, I would be very grateful. Thanks for your review...

Should be fixed via 36e55c7fb803989e9c5d6ab8f254997e3d400fdf, however I thought that was a simple user error and should not be caught.

I tried that, it must be 4 in default or 5 in store and website. But then again, you don't know if some field name contains double underscores for whatever...

Maybe we should allow `-`? Its not quite uncommon to have `-` in field,group,section or store_code, yes?

> i was thinking, do all of the methods in Mage_Core_Helper_EnvironmentConfigLoader have to be public? Probably not. I'll check and change visibility accordingly. I've probably done it for the tests?