osu-framework icon indicating copy to clipboard operation
osu-framework copied to clipboard

FFmpeg Linux binaries: Include version in file name

Open FreezyLemon opened this issue 1 year ago • 1 comments

I explain the rationale behind this change in #6154.

The included patch is necessary for local builds on some distros, and it will become necessary on more distros (and CI) as binutils gets updated (ver 2.41 breaks the ffmpeg build).

Note that the new NativeLibs version will cause the current logic to not find the new libraries. See the linked PR for the required logic change.

FreezyLemon avatar Jan 28 '24 22:01 FreezyLemon

I've been playing around with using newer FFmpeg versions (>=5.0) in osu-framework and I noticed that FFmpeg.AutoGen had a major API change at some point.

Edit (disregard previous comment version): The API has changed, but it looks like there are still ways to get more control over library loading (it looks like it's even possible to delete the Linux workaround regarding RTLD_GLOBAL.

Note for later: It looks like it's possible to inject a custom FunctionResolver before Initialize is called, which actually seems nicer than the current GetOrLoadLibrary API.

FreezyLemon avatar Feb 19 '24 15:02 FreezyLemon