resizablelib icon indicating copy to clipboard operation
resizablelib copied to clipboard

Test hidden modeless dialog

Open ppescher opened this issue 1 year ago • 4 comments

Address save/restore on a modeless dialog initially hidden, that was incorrectly making it visible during initialization.

Now the restore process is postponed until the dialog is made visible for the first time, preventing the override of the initial hidden state.

See pull request #32 for details. Anyone interested please try this patch also in your own use cases, to confirm it does what it's supposed to and there are no unexpected side-effects.

ppescher avatar Sep 02 '24 17:09 ppescher

Moved this comment to the correct PR. The changes so far look good; dialogs with visible initial state behaved as usual.

irwir avatar Sep 02 '24 19:09 irwir

This fixes the issue for mpc-hc after removal of our custom code.

adipose avatar Sep 04 '24 15:09 adipose

Nice! I will propagate this change to the other dialog flavors.

ppescher avatar Sep 05 '24 08:09 ppescher

Any chance of this making it to master soon?

I have updated mpc-hc code to take advantage but I would like it to be based on commited code.

adipose avatar Sep 25 '24 00:09 adipose

@ppescher will this make it to the main branch?

adipose avatar Dec 09 '24 02:12 adipose

Sorry, I've been completely carried away from this. Merged.

ppescher avatar Dec 09 '24 11:12 ppescher