Joshua Powers

Results 758 comments of Joshua Powers

Hi, I'm going to have the team review the PR and probably land this. Our next release is coming up and I don't want to miss this. Thanks!

@leetreveil is this something you are still interested in?

@davidby-influx could we get Stuart's review on this PR? While not urgent, it would be nice to keep up the momentum on this. @alespour I have two comments: - In...

Hi, > tls: handshake failure Can you: 1) Confirm what cipher your server is using? (e.g. `openssl s_client -connect myhost.mydomain.com:636`) 2) Confirm this is consistently happening? 3) When you upgraded...

> To narrow down the issue, we upgrade from last known working version 1.29.2-1 Thank you very much for doing this. I think this does possibly narrow it down to...

Hi, Would be happy to circle back around on this PR after the above changes are made. Thanks!

@ZPascal I see this is a draft, are you actually ready for a review once the lint issue is resolved?

> These metrics are not part of the CMS. I'm currently thinking about renaming the plugin. What do you think of this idea? Check my understanding: CMS is the Cloud...

> I have introduced a [generic parameter that provides the basic function for the plugin](https://github.com/influxdata/telegraf/blob/a25731ca6daddcccdb72ed26c08926cc3b40be53/plugins/inputs/aliyuncms/sample.conf#L23) and in the [second step activates the function for the RDS service](https://github.com/influxdata/telegraf/blob/a25731ca6daddcccdb72ed26c08926cc3b40be53/plugins/inputs/aliyuncms/aliyuncms.go#L68). We discourage boolean...

I'm going to re-open as @ZPascal I think you've been going through and updating the PRs and we were nearly done with this one.