Joshua Powers
Joshua Powers
@julesroussel3 any update on this PR? Thanks!
> I believe all of the recent comments have been addressed. Thanks I will take a look tomorrow > The readme linter is complaining, but only about plugin READMEs unrelated...
Thanks for seeing this through. I'll let Sven take one final look at this.
@DStrand1 can you post your notes please and we can then revisit the next steps?
Per discussion closing this PR. Thanks for putting this up, but we agree the gain from this PR is limited, while possibly causing some breaking issues for users.
> The actual intention of this request is to be able to compare performance between different plugins.. Both the parsers and serializers do not always use the same data, data...
@x448, Thanks for calling this out. @srebhan - it looks like we pull in cbor indirectly via your cborquery repo. That is set to v1.5.1. Could you update the version...
> I could try to land that one separately after this one is merged I would much rather see two PRs over one very large one.
@athornton here is a diff to clean up the `go mod tidy` issues: ```diff diff --git a/go.mod b/go.mod index 3b95a4eca..1f992bfc8 100644 --- a/go.mod +++ b/go.mod @@ -107,7 +107,7 @@ require...
As we are not planning on doing a Telegraf 2.x at this time anymore, I am closing breaking changes issues and PRs. While we have interest in making these improvements...