ember-changeset-validations icon indicating copy to clipboard operation
ember-changeset-validations copied to clipboard

(Octane) skipValidate=true in helper does not work

Open dantel35 opened this issue 4 years ago • 2 comments

Hi, I am on a freshly created octane ember project with ember-changeset and ember-changeset-validations installed. I am not sure if this is the same as #147 but passing the skipValidate=true option like documented in ember-changeset:

{{#with (changeset this.model this.AccountValidations skipValidate=true ) as |changesetObj|}}

does not do anything, it is still automatically validating. Doing it manually in JavaScript does work:

 constructor() {
    super(...arguments);
    this.changeset = new Changeset(this.args.model, lookupValidator(AccountValidations), AccountValidations, { skipValidate: true });
  }

Am I doing it wrong or is it still a bug?

dantel35 avatar Mar 20 '21 14:03 dantel35

@dantel35 👋 I took a look at this and I'm having trouble seeing where the issue might be. Do you have a simple reproduction app I can look at?

snewcomer avatar Mar 31 '21 14:03 snewcomer

@snewcomer yes, here you go: https://github.com/dantel35/ember-validation-bug

dantel35 avatar Apr 02 '21 11:04 dantel35