ember-changeset-validations icon indicating copy to clipboard operation
ember-changeset-validations copied to clipboard

[PROPOSAL] Move core validators to separate TS library

Open snewcomer opened this issue 5 years ago • 1 comments

Similar to the work that went into ember-changeset, we can extract the core validators to a general typescript/javascript library. This necessitates looking at how we can generalize ember-validators to the greater JS community as well. I suspect this work would be relatively simple and would pair well with the new validated-changeset library.

https://github.com/validated-changeset/validated-changeset

snewcomer avatar Dec 28 '19 16:12 snewcomer

While I understand the idea, I actually think it would be better to go in the opposite direction.

For certain open-source projects, it makes sense to abstract things away and turn the project into a building-block for others. But there are also a lot of costs associated with that path. More complexity, more work to maintain, higher threshold for new contributors, etc.

Somewhat related, I'd suggest inlining validated-changeset instead:

https://github.com/poteto/ember-changeset-validations/discussions/306

sandstrom avatar Jul 02 '21 13:07 sandstrom