postman-collection
postman-collection copied to clipboard
Update variable description on upsert
Fixes #740
Issue
Variable description is not updating on upsert.
const list = new VariableList(null, [{
key: 'k1',
value: 'initial',
description: 'initial description'
}]);
list.upsert({
key: 'k1',
value: 'updated',
description: 'updated description'
});
list.toJSON();
// [{
// description: {
// content: 'initial description',
// type: 'text/plain'
// },
// type: 'any',
// value: 'updated',
// key: 'k1'
// }]
Fix
Update description also on variable upsert.
Validation
Changes validated locally.
@codenirvana @shamasis please review the PR
Codecov Report
Merging #998 into develop will increase coverage by
0.00%. The diff coverage is100.00%.
@@ Coverage Diff @@
## develop #998 +/- ##
========================================
Coverage 96.87% 96.88%
========================================
Files 39 39
Lines 2369 2372 +3
Branches 703 704 +1
========================================
+ Hits 2295 2298 +3
Misses 74 74
| Flag | Coverage Δ | |
|---|---|---|
| #unit | 96.88% <100.00%> (+<0.01%) |
:arrow_up: |
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/collection/variable.js | 96.73% <100.00%> (+0.10%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 1630c09...cab1dbe. Read the comment docs.
@codenirvana added the unit tests for the changes made
deferring because the same issue is present in other Property.
Closing in favor of #1332