newman
newman copied to clipboard
Change the sequence to use object destructuring
As I was going through the codebase, I came across this comment
// @todo: ES6: Change the sequence below to use object destructuring when Node v4 support is dropped
joinPath = nodePath.join,
parsePath = nodePath.parse,
resolvePath = nodePath.resolve,
As Node v4 support has been dropped, I think it's safe to use Object destructing instead.
Codecov Report
Merging #2658 (c96a7a8) into develop (24d13f7) will decrease coverage by
0.01%. The diff coverage is100.00%.
@@ Coverage Diff @@
## develop #2658 +/- ##
===========================================
- Coverage 90.84% 90.82% -0.02%
===========================================
Files 21 21
Lines 1103 1101 -2
Branches 334 334
===========================================
- Hits 1002 1000 -2
Misses 101 101
| Flag | Coverage Δ | |
|---|---|---|
| cli | 82.37% <100.00%> (-0.04%) |
:arrow_down: |
| integration | 42.23% <100.00%> (-0.11%) |
:arrow_down: |
| library | 60.58% <100.00%> (-0.08%) |
:arrow_down: |
| unit | 76.93% <100.00%> (-0.05%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/run/export-file.js | 89.58% <100.00%> (-0.42%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 24d13f7...c96a7a8. Read the comment docs.
Can you check why tests are failing?
Can it be due to the removed lines? But they are still being tested, so not really sure why this is happening. I will look further.
