pg_wait_sampling

pg_wait_sampling copied to clipboard

Integrate isolation tests for more granular testing

13

Many buggy cases require for their reproducing non-trivial scenarios with multiple sessions. The isolation test utility is a good choice to emulate these scenarios. Additionally isolation tests, in general, allow...

maksm90

[refer #PGPRO-6599]: Avoid race conditions while processing PROFILE_R…

3

…EQUEST and PROFILE_RESET requests. After initialization of "request" variable in collector.c main loop, another client backend could change the value of "collector_hdr->request" variable. Changing this value from "PROFILE_RESET" to "PROFILE_REQUEST"...

rzharkov

Add building/testing PG14 and PG15beta1 in TravisCI

1

maksm90

pg_wait_sampling tracks queryId just for top-level queries

13

Recently there was discussion https://github.com/postgrespro/pg_wait_sampling/pull/42#issuecomment-1079635726 about unwanted usage of queryIds taken from `PgBackendStatus` entries in `BackendStatusArray` as they represent only top-level queries. But current implementation behave in similar manner: once...

maksm90

queryid is cleared too early with nested queries

1

Here is a demo using two sessions distinguished with indentation: ``` postgres=# select * from pg_wait_sampling_current where pid = 65936; pid | event_type | event | queryid -------+------------+------------+--------- 65936 |...

shinderuk

Synchronization with collector may be lost if backend is terminated

1

Consider the following scenario: 1. Session 1 requests history. 2. Session 1 is terminated while wating for collector. 3. Session 2 requests profile. 4. Collector sends history requested by session...

shinderuk

queryid not cleared after error or cancellation

1

Here is a demo using two session distinguished with indentation: ``` postgres=# select * from pg_wait_sampling_current where pid = 65593; pid | event_type | event | queryid -------+------------+------------+--------- 65593 |...

shinderuk

They probably should be in a header. On Linux: ``` $ objdump -d pg_wait_sampling.so | grep -i 'call.*compat' 3e4c: e8 8f f7 ff ff callq 35e0 47b4: e8 97 ef...

shinderuk

Queryid is always 0 with utility statements

1

Hello, Queryid for utility statements are 0 in pg_stat_statements until their end. Maybe that queryid should be computed in pg_wait_sampling using the same pgss_hash_string() function. Regards PAscal

legrandlegrand

infinite Lock userlock during select count(*) from pg_wait_sampling_history;

1

Good day. During query from pg_wait_sampling_history session infinite wait. Query from pg_wait_sampling_current working. config: pg_wait_sampling.history_period | 100 pg_wait_sampling.history_size | 5000 pg_wait_sampling.profile_period | 100 pg_wait_sampling.profile_pid | on pg_wait_sampling.profile_queries | on SELECT...

grin31