pg_probackup icon indicating copy to clipboard operation
pg_probackup copied to clipboard

Repair backup failed (the value of segment_size is greater than 2G)

Open hslightdb opened this issue 3 years ago • 5 comments

If the value of segment_size is greater than 2G, the file length will overflow. In this case, the backup will fail.

hslightdb avatar Jul 14 '22 05:07 hslightdb

@funny-falcon ,I see this problem still exists, are there any plans to fix this?

qiuwenhuifx avatar Aug 24 '23 08:08 qiuwenhuifx

@funny-falcon INFO: Backup files are synced, time elapsed: 0 INFO: Validating backup RZW6OO ERROR: Cannot seek block 261889 of "/data00/pgsql/backup/backups/pg_5436/RZW6OO/database/base/16393/16440.1": Invalid argument ERROR: Data files validation failed pgsql@n97-16-066:~$ du -sh /data00/pgsql/backup/backups/pg_5436/RZW6OO/database/base/16393/16440.1 2.4G /data00/pgsql/backup/backups/pg_5436/RZW6OO/database/base/16393/16440.1

qiuwenhuifx avatar Aug 24 '23 11:08 qiuwenhuifx

Currently there are no plans to fix it, since it quite hard due to backward compatibility issues.

funny-falcon avatar Oct 10 '23 17:10 funny-falcon

Ah, I see: your patch is quite capable. Ok, let me think once more.

funny-falcon avatar Oct 10 '23 17:10 funny-falcon

@funny-falcon ,It seems n_blocks variable type is int ( file->n_blocks = (int) n_blocks) ,postgrespro has already fixed the (xid 32bit) issue, I think no reason why it can't be fixed!,Thank you very much

qiuwenhuifx avatar Nov 03 '23 06:11 qiuwenhuifx