shiny-vscode icon indicating copy to clipboard operation
shiny-vscode copied to clipboard

Extension ID renaming plan

Open jcheng5 opened this issue 1 year ago • 2 comments

In mid-May (when Joe gets back from vacation):

  • [ ] Publish new extension under Posit.shiny
  • [ ] Simultaneously, publish new version of Posit.shiny-python that removes all contribution points and depends on Posit.shiny, and rename to "[Deprecated] ..."
  • [ ] Unpublish the very old, long-deprecated rstudio.pyshiny so we don't have two deprecated extensions showing up in search
  • [ ] Review usage of Posit.shiny-python and PR the name change (e.g. Posit.shiny-python is a recommended extension in py-shiny)

jcheng5 avatar May 03 '24 16:05 jcheng5

A good outline of the process: https://github.com/microsoft/vscode/issues/59918#issuecomment-483412662

gadenbuie avatar May 21 '24 14:05 gadenbuie

Apparently we can also add a note in this thread for an official deprecation notice in the extension marketplace https://github.com/microsoft/vscode-discussions/discussions/1

This seems to be effective only for marketplace.visualstudio.com, I can't find a way to rename or remove an extension on open-vsx.org.

gadenbuie avatar May 21 '24 14:05 gadenbuie

Unanticipated fun! We couldn't publish the new extension to the VS Code Marketplace because the new Posit.shiny extension has the same name as the old Posit.shiny-python extension, and the marketplace threw an error:

Error: Error: Extension Posit.shiny 1.0.0 is already published.

So I had to publish the old extension first to change the name. Then our CI failed to push the Posit.shiny extension to the marketplace because the Open-VSX publishing threw this error

Error: Extension Posit.shiny 1.0.0 is already published.

So I quickly edited the CI to separate the build steps into two separate jobs in https://github.com/posit-dev/shiny-vscode/commit/c348df2b68dce61dffd3dd75adc232a653363460 (thanks @schloerke for the quick pairing session!). We first build the .vsix to check that everything will work and the separate build steps depend on the success of the first vsix build.

I think we can streamline the jobs even more and have the publish steps use the vsix artifact from the first job, or at least we don't need to include the build vsix step in the publish jobs.

gadenbuie avatar May 29 '24 14:05 gadenbuie