rsconnect-python
rsconnect-python copied to clipboard
Edit inline help to correctly list Cloud and shinyapps.io support
Intent
Fixes #481
Type of Change
- [x] Bug Fix
- [ ] New Feature
- [ ] Breaking Change
Approach
Make the kinds of systems that are supported (Connect, Cloud, shinyapps.io) a property of AppModes
Automated Tests
I'm not a regular contributor to this repo and wanted to do more than chuck an issue over the fence. Happy to add tests if someone familiar with rsconnect-python wants to suggest specific kinds of tests to add.
Directions for Reviewers
Run rsconnect deploy. Verify that
- All deploy subcommands listed in help are advertised as supported by Connect
- API, bokeh, dash, fastapi, html, quarto, shiny, and streamlit are also advertised as supported by Cloud
- shiny is also advertised as supported by shinyapps.io.
Repeat for rsconnect deploy api, rsconnect deploy shiny etc. (check full command help description)
Checklist
- [ ] I have updated CHANGELOG.md to cover notable changes.
- [ ] I have updated all related GitHub issues to reflect their current state.
☂️ Python Coverage
current status: ✅
Overall Coverage
| Lines | Covered | Coverage | Threshold | Status |
|---|---|---|---|---|
| 4305 | 2795 | 65% | 0% | 🟢 |
New Files
No new covered files...
Modified Files
| File | Coverage | Status |
|---|---|---|
| rsconnect/main.py | 55% | 🟢 |
| rsconnect/models.py | 78% | 🟢 |
| TOTAL | 66% | 🟢 |
updated for commit:
08e2eb6by action🐍