code-surfer icon indicating copy to clipboard operation
code-surfer copied to clipboard

Published 20 hours ago • verified publisher icon pomber

Make CodeSurfer compatible with mdx-deck 2.x

Open vlsi opened this issue 6 years ago • 4 comments

Note: this is my first yarn/React experience, so the change might be off the track. However the support for mdx-deck 2.x seems to be not that difficult.

fixes #53

vlsi avatar Mar 24 '19 13:03 vlsi

PS I have no idea why react-docs fails to build:

$ yarn build
yarn run v1.12.3
$ docz build
{ parser: "babylon" } is deprecated; we now treat it as { parser: "babel" }.
▶  start     Creating an optimized production build...
✖  fatal     Failed to compile.

./.docz/app/root.jsx
Module not found: Can't resolve 'null' in '..../code-surfer/fixtures/react-docs/.docz/app'

vlsi avatar Mar 24 '19 14:03 vlsi

website failure seems to be the same as https://github.com/jxnblk/mdx-deck/issues/284 (gatsby still depends on mdx v1 which does not play well with mdx-deck 2)

vlsi avatar Mar 25 '19 19:03 vlsi

For what it's worth, this worked for me. @pomber any plans to merge and publish support for this?

AndersDJohnson avatar May 05 '19 18:05 AndersDJohnson

Just in case: beware that mdx-deck has lots of pitfalls for delivering slides on stage. It looks good when you start, however, there are small bits that appear out of thin air (e.g. lack of 16x9, lack of positioning, wrong "next slide" in speaker view, etc, etc), and it is especially painful in case you prepare the slides "a week before the event".

vlsi avatar May 05 '19 19:05 vlsi