Polypheny-DB icon indicating copy to clipboard operation
Polypheny-DB copied to clipboard

More space in Plan Builder

Open vogti opened this issue 5 years ago • 28 comments

Increase the available space in the Plan Builder. Allow horizontal and vertical scrolling if necessary. It might make sense to move the query results to an independent page.

vogti avatar Feb 01 '20 19:02 vogti

Hi, I am Paras Sharma. I would like to participate in GSOC 2021 and contribute to this project. I want to start this by solving this issue.

parassharm80 avatar Mar 26 '21 19:03 parassharm80

Hi @parassharm80, welcome to Polypheny! I have assigned the issue to you. Please follow this on how to set up Polypheny-DB in your favorite IDE and this guide on how to manually build Polypheny-UI. Feel free to ask here or open a thread in the discussions forum if you have any questions or experience any issues with setup.

vogti avatar Mar 26 '21 21:03 vogti

Hi @parassharm80, is everything working fine? If you have any issues or need help getting started, please do not hesitate to either ask here or open a thread in the discussion forum.

vogti avatar Apr 02 '21 09:04 vogti

Hi @vogti , This #184 (inactive) issue and i will prefer to contribute in it if @parassharm80 may don't have any issue regarding it.

Pawanupadhyay10 avatar Apr 09 '21 15:04 Pawanupadhyay10

@parassharm80 Are you still working on this issue?

vogti avatar Apr 09 '21 15:04 vogti

Hi, I am stuck on other projects. You can assign this to someone else

parassharm80 avatar Apr 09 '21 17:04 parassharm80

Thanks, @parassharm80, for the feedback. @Pawanupadhyay10 I have assigned the issue to you.

vogti avatar Apr 09 '21 18:04 vogti

Hi @vogti can you make this task more easy to understand via providing a vedio .

Pawanupadhyay10 avatar Apr 11 '21 05:04 Pawanupadhyay10

Since this is an enhancement and not a bug, it is not really possible to create a video. But I can of course help you to understand the idea of this issue. Which part is unclear for you?

vogti avatar Apr 11 '21 16:04 vogti

image

Hi, @vogti vertical scrolling is already there ,and about spacing ,in which part/area I need to add more space .This is not clear to me,Kindly guide me so that ,issue can be completed soon.

Pawanupadhyay10 avatar Apr 12 '21 12:04 Pawanupadhyay10

Hi @Pawanupadhyay10 this issue is about the plan builder (like #255).

vogti avatar Apr 12 '21 12:04 vogti

Hey @vogti please ,see image above I shared, where I need clarity.

Pawanupadhyay10 avatar Apr 12 '21 13:04 Pawanupadhyay10

The space is limited by the window size. There is no horizontal scrolling and vertical scrolling is limited.

vogti avatar Apr 12 '21 13:04 vogti

image

HI,@vogti I have added the horizontal scroll bar and more space in plan builder please see the image attached.

Pawanupadhyay10 avatar Apr 16 '21 09:04 Pawanupadhyay10

Hi,@vogti, please have look on My PR.Thanks.

Pawanupadhyay10 avatar Apr 16 '21 11:04 Pawanupadhyay10

Hi @Pawanupadhyay10, while your solution does indeed increase the available space on smaller screens, it limits the space on larger screens. So that makes things even worse.

To fix this problem, a more sophisticated solution is required. The idea would be to have an infinite space.

vogti avatar Apr 17 '21 15:04 vogti

ok,@vogti, but as issue is closed ,how can I improve it.

Pawanupadhyay10 avatar Apr 17 '21 15:04 Pawanupadhyay10

Can ,i start with a new issue.

Pawanupadhyay10 avatar Apr 17 '21 15:04 Pawanupadhyay10

I have only closed the PR, not the issue. You can simply open a new pull request with the improved solution for this problem.

vogti avatar Apr 17 '21 15:04 vogti

ok,Thanks.

Pawanupadhyay10 avatar Apr 17 '21 15:04 Pawanupadhyay10

Of course, shall I unassign you from this issue?

vogti avatar Apr 17 '21 15:04 vogti

I am thinking for better solution ,but if you like to assign me new issue, I have no problem then.

Pawanupadhyay10 avatar Apr 17 '21 15:04 Pawanupadhyay10

Oh, then I misunderstood you. I thought you ask whether you can work on a new issue (instead of this one).

vogti avatar Apr 17 '21 15:04 vogti

Hi,@vogti , please have a look now , for better solution in my PR.

Pawanupadhyay10 avatar Apr 18 '21 12:04 Pawanupadhyay10

hi.@vogti have a look on the PR.

Pawanupadhyay10 avatar Apr 25 '21 05:04 Pawanupadhyay10

Hi @Pawanupadhyay10, thanks for the pull request. Unfortunately, this is still not a proper solution. While it no longer limits the available space on larger screens, the available space is still static. Since the run button is only accessible by scrolling, your change makes the plan builder difficult to use. As I pointed out in one of my previous comments, fixing this issue requires a more sophisticated approach. It might be better if you first think of an approach on how to address this. We can then discuss this.

vogti avatar Apr 25 '21 12:04 vogti

Okay@vogti.

Pawanupadhyay10 avatar Apr 25 '21 13:04 Pawanupadhyay10

@vogti Hi, can you assign me this issue, I believe i can solve it

EslamAsHhraf avatar Apr 01 '24 00:04 EslamAsHhraf