Paul O'Leary McCann

I checked and it looks like this util function isn't used in any of our other repos, so it looks like it'll be safe to remove. One thing is that...

Still dealing with some issues with tests, but current status is: The `split_command` function has been removed and replaced with `shlex.split` where appropriate. For Windows command strings are used instead,...

After review I believe the current state of this is reasonable. The only thing not handled equivalently on Windows at the moment is rewriting commands that start with `python` or...

> Also, this comment hasn't been addressed - I was talking about shlex.quote specifically. Do you mean `join_command`? I left that since it isn't used in `run_command` and won't be...

In its previous state, I had left out a line in `run_commands`, resulting in breaking projects on Windows (nothing would run). That has been resolved. I think the current state...

I have run several projects with the latest state of this on Windows and Linux without issue, so that should be working at least. I need to test the DVC...

There were some issues with the DVC command that weren't directly related to quoting issues that have been fixed. Mainly, if you used the `--verbose` flag when calling `spacy project...

OK, I ran DVC on Windows and checked that quoted paths work. I found one more minor issue in DVC (not related to quoting) that should be resolved now. If...

OK, tests are green. I have commented on a few places I'd like feedback, but I think the current state is acceptable. If no changes are required the one thing...

On Windows I have a Git Bash shell which I'm using for these tests. I have a virtualenv with spaCy installed and the projects repo checked out, and I can...