action-setup icon indicating copy to clipboard operation
action-setup copied to clipboard

Published 20 hours ago • verified publisher icon pnpm

Pnpm 7 support

Open gunta opened this issue 3 years ago • 6 comments

Checking here I can see the install script is using https://get.pnpm.io/v6.16.js https://github.com/pnpm/action-setup/blob/10b4b0b462cfa1a30381c9d7c242194165a466ab/src/install-pnpm/run.ts#L25

Given that the latest 7 version is using https://get.pnpm.io/install.sh as the new install script, is there any change for the process? I can see that the new script is very simple and basically downloads the binary from npm.

gunta avatar Apr 25 '22 23:04 gunta

The caching examples will need to be updated as the store is now in a new location.

nicksrandall avatar May 03 '22 22:05 nicksrandall

I don't get it. Why do fetch('https://get.pnpm.io/v6.16.js') at all for users who have specified packageManager in the package.json? It'd be nice if that field could be used without first downloading a file from a hardcoded version

benmccann avatar May 11 '22 16:05 benmccann

That file is only used to install pnpm. https://get.pnpm.io/v6.16.js will not install pnpm v6.16.

zkochan avatar May 12 '22 10:05 zkochan

FYI, this action is working with pnpm 7 for me, using these steps: https://pnpm.io/continuous-integration#github-actions

michaelhays avatar May 13 '22 18:05 michaelhays

Working for me too with the example on the pnpm website, which uses action/setup-node's built-in caching feature. This repo's README should probably be updated accordingly. I would just add --frozen-lockfile to the dependencies installation step, though, like in this example from action/setup-node.

axelboc avatar May 25 '22 09:05 axelboc

It seems like this issue should be closed because pnpm/action-setup works fine with pnpm@7 and pnpm@8

tksst avatar Mar 29 '23 03:03 tksst