sp-dev-fx-property-controls icon indicating copy to clipboard operation
sp-dev-fx-property-controls copied to clipboard

TreeCollection & RuleCollection (Conditional Tree Builder)

Open edarroudi opened this issue 3 years ago • 1 comments

Q A
New feature? [X]
Related issues? mentioned in #451

What's in this Pull Request?

Added a common TreeCollection control that features:

  • Row dependend Fields: e.g. show field x,y in root, and z on level 1
  • Row Fields are based on the collectionData component
  • MultiRoot Trees

Added a RuleTree (Condition Builder Tree) based on the TreeCollection component above, featuring:

  • Building complex conditions
  • Will feature "Autocomplete" Tokens in the future
  • Will feature "Evaluation" of the current Context when property pane is opened
  • Will feature custom condtions

What are the next todos for this feature branch:

  • Discuss interface
  • Discuss layout
  • Implement Evaluation of the current Context for RuleTree
  • Implement custom conditions for RuleTree
  • Finish localisation / Replace const labels
  • Refactoring
  • Documentation
  • Full Tests

What are the optional todos for the next feature branch:

  • Maybe Autocomplete

Any comment is appreciated. I think the trees don't need to support a lot of items so I didn't optimize it for speed. The RuleBuilder might look a bit confusing at first but I think users will be able to work with that.

Below are some screenshots...

image

image

image image image image image image

edarroudi avatar May 17 '22 21:05 edarroudi

@edarroudi - thank you very much for this PR. And I'm really sorry for the long delay. I left some comments. Promise to be more responsive :)

@AJIXuMuK - no worries! Thank your for your reply and your comments. I tend to optimize and refactor the code once the overall "Architecture", Layout and Features are discussed and approved. I believe now that you don't have any problems with the overall approach and will a) change the code according to your commets and b) add the Evaluation and Custom conditions code.

edarroudi avatar Sep 20 '22 07:09 edarroudi