sp-dev-fx-controls-react icon indicating copy to clipboard operation
sp-dev-fx-controls-react copied to clipboard

Published 20 hours ago • verified publisher icon pnp

Updated visibility of controls in the ControlsTest web part

Open GuidoZam opened this issue 11 months ago • 2 comments

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]

What's in this Pull Request?

This pull request is to fix the display of the ListItemAttachments control in the ControlsTest web part. The web part was always showing the ListItemAttachments control, now it can be displayed or hide as all the other controls.

GuidoZam avatar Dec 29 '24 16:12 GuidoZam

hey @GuidoZam - thank you for the PR! Could you please resolve the conflicts?

AJIXuMuK avatar Mar 02 '25 18:03 AJIXuMuK

Hi @GuidoZam,

I just noticed your PR regarding controls visibility. I already pushed update for the whole testing web part without noticing your proposal, really sorry about that 🫤

Feel free to update the PR with other improvments if you found some or to close it otherwise.

As an improvment idea, I was thinking about adding new property pane options for each control, so that you can better test each one of them without going back and forth in the code to manually update values. If you'd like to submit something regarding this, please do.

michaelmaillot avatar Mar 13 '25 09:03 michaelmaillot

Hey @GuidoZam,

Did you think about what to do with this PR?

michaelmaillot avatar Jun 30 '25 16:06 michaelmaillot

@GuidoZam Have you had the opportunity to see this? Thanks.

joaojmendes avatar Jul 13 '25 20:07 joaojmendes

Hi @joaojmendes I think this can be closed. I will open a new PR if I will be able to do what @michaelmaillot wrote before.

GuidoZam avatar Jul 25 '25 12:07 GuidoZam