node-sass-json-importer icon indicating copy to clipboard operation
node-sass-json-importer copied to clipboard

Update to dart-sass?

Open willbuckingham opened this issue 4 years ago • 2 comments
trafficstars

With the deprecation of LibSass / node-sass https://sass-lang.com/blog/libsass-is-deprecated , do you intend to change the peer dependency to sass?

Both have the same JS Api. https://sass-lang.com/documentation/js-api

And they seem to work fine with this importer, however you get a terminal warning about unmet peer dependencies. Honestly not sure if there's a way to make it an either/or peer dependency. OR perhaps a rebrand of this library is coming down the line.

willbuckingham avatar Mar 09 '21 17:03 willbuckingham

Yes, would love to see this work with dart-sass without getting the terminal warning

brandonkramer avatar Mar 10 '21 11:03 brandonkramer

I've been using this with dart-sass regularly and it seems to be working fine, apart from the warning. Worth splitting into a node-sass release and a dart-sass release?

Or, alternatively, what about not having any peer dependencies defined, and then include a check somewhere to only warn if the user has no version of Sass installed?

rootwork avatar May 21 '21 21:05 rootwork