react-three-fiber icon indicating copy to clipboard operation
react-three-fiber copied to clipboard

Published 20 hours ago • verified publisher icon pmndrs

pointerenter and pointerleave semantics

Open Skagoo opened this issue 2 years ago • 3 comments

I stumbled on an issue where onPointerLeave was invoked unexpectedly. It is invoked when releasing the pointer, making it act identical to onPointerOut. Thanks to the well maintained docs I found this is indeed how it is currently implemented.

Is there anything planned to implement pointerenter and pointerleave semantics? If no, would you be open for a PR?

Skagoo avatar Jan 05 '23 01:01 Skagoo

We intend for those to behave like their DOM counterparts, so I'm treating this as a bug.

I'd be happy to accept and review a PR or any ideas on how to address this, as this is a weak part of the library.

CodyJasonBennett avatar Jan 21 '23 20:01 CodyJasonBennett

Alright, thanks to confirm this. I'll see what I can do, hoping to open a PR soon.

Skagoo avatar Jan 21 '23 22:01 Skagoo

Folks, please check fix in this PR https://github.com/pmndrs/react-three-fiber/pull/2764

mvp-v avatar Feb 20 '23 17:02 mvp-v