PocketMine-MP icon indicating copy to clipboard operation
PocketMine-MP copied to clipboard

Add API functions for Fly speed.

Open TheDataLioness opened this issue 3 years ago • 3 comments

Introduction

Since the new 1.19.10 update added the Walk and Fly speed feature to the new AbilityPacket. These values were hardcoded

Changes

API changes

Added $player->setFlySpeed(); Added $player->getFlySpeed(); Added $player->resetFlySpeed();

Added $player->setWalkSpeed(); Added $player->getWalkSpeed(); Added $player->resetWalkSpeed();

Tests

https://user-images.githubusercontent.com/34657342/178804701-eee1ee4c-cc99-4d72-9b1f-bf3c0a47aa89.mp4

TheDataLioness avatar Jul 13 '22 18:07 TheDataLioness

I'm not clear on what the value of setWalkSpeed is, since we already have an attribute-controlled setMovementSpeed which influences this. I'm open to reasoning.

dktapps avatar Aug 14 '22 16:08 dktapps

Well I've removed that function already because of that reason. But I forgot to push it. I'm on vacation right now so haven't really had the time to commit the changes.

TheDataLioness avatar Aug 14 '22 17:08 TheDataLioness

ok but there won't be any chunk bug on some "big" server ?

AzaleeX avatar Sep 16 '22 15:09 AzaleeX

@TheDataLioness any updates for this PR? If not it will be closed when API 5 releases

jasonw4331 avatar Mar 17 '23 15:03 jasonw4331

@jasonwynn10 haven't touched PM in ages.

TheDataLioness avatar Mar 17 '23 15:03 TheDataLioness

Closing due to lack of activity on review comments.

dktapps avatar Oct 24 '23 11:10 dktapps