PocketMine-MP
PocketMine-MP copied to clipboard
pmmp
Added missing drops for Bell
Introduction
Add missing drops for Bell
Relevant issues
None
Changes
API changes
None
Behavioural changes
N/A
Backwards compatibility
N/A
Follow-up
N/A
Tests
None
Attach scripts or actions to test this pull request, as well as the result N/A
Please ~~rebase onto next-minor instead of stable~~ merge into stable instead of next-minor
This is actually pointless anyway, since blocks already drop themselves by default if the correct tool was used. This does nothing useful.
This is actually pointless anyway, since blocks already drop themselves by default if the correct tool was used. This does nothing useful.
but what about being destroyed by nearby update?
That's a general problem not specific to bells. This change causes an additional bug, which is that it drops when any tool is used (or none at all).
That's a general problem not specific to bells. This change causes an additional bug, which is that it drops when any tool is used (or none at all).
Bell got dropped by any tools and none too.
https://user-images.githubusercontent.com/54394881/152657479-655694e6-8c17-4da7-a450-ad9ddc49de0f.mp4
Even if that were true, overriding getDrops() is not the way to deal with it - that breaks a bunch of other things.
