PocketMine-MP icon indicating copy to clipboard operation
PocketMine-MP copied to clipboard

Added Type NBT data for illager banners

Open jasonw4331 opened this issue 4 years ago • 4 comments

Introduction

Banners can now be set and used as the illager type.

Relevant issues

Fixes #2951

Changes

API changes

6 new functions: item\Banner::isIllagerPattern() item\Banner::setIllagerPattern(bool) tile\Banner::isIllagerPattern() tile\Banner::setIllagerPattern(bool) block\BaseBanner::isIllagerPattern() block\BaseBanner::setIllagerPattern(bool)

Behavioral changes

N/A

Backwards compatibility

N/A

Follow-up

WIP

Tests

Pending Tests

jasonw4331 avatar Jun 04 '21 01:06 jasonw4331

I’d like to fix the banners which are stored in the creative inventory next. What’s the best place for the server recognize the difference in nbt sent from the client?

jasonw4331 avatar Jun 04 '21 12:06 jasonw4331

These APIs should also be provided in block\BaseBanner.

dktapps avatar Jun 04 '21 12:06 dktapps

It would be nice if you would test what happens when an illager banner receives extra patterns. I don't think there's a way to do that in vanilla.

dktapps avatar Jun 05 '21 13:06 dktapps

When the illager banner type is set, any pattern layers turn into this:

image

jasonw4331 avatar Jun 05 '21 14:06 jasonw4331

Since this creates conditionally useless APIs (and is also 2 years obsolete), I'm going to close this. The new serializer system in PM5 should facilitate dealing with illager banners in a better way.

dktapps avatar May 29 '23 20:05 dktapps