libpmemobj-cpp icon indicating copy to clipboard operation
libpmemobj-cpp copied to clipboard

Missing checks for switching containers on/off

Open lukaszstolarczuk opened this issue 5 years ago • 0 comments

We should have checks in CI for switching containers on and off (using CMake options https://github.com/pmem/libpmemobj-cpp/blob/master/CMakeLists.txt#L60). We can do this similarly like engine's checks in pmemkv (see: https://github.com/pmem/pmemkv/blob/master/utils/docker/run-test-building.sh#L138), but we should not only check if it compiles properly, but also if proper file list is included/installed.

It could be done along with other checks in CI (see #204). hence new file (e.g. run-test-building.sh) should be most likely created.

lukaszstolarczuk avatar Jul 30 '20 11:07 lukaszstolarczuk