libpmemobj-cpp icon indicating copy to clipboard operation
libpmemobj-cpp copied to clipboard

Generated [deb] package contains compatibility tests

Open lukaszstolarczuk opened this issue 4 years ago • 0 comments

Environment Information

  • libpmemobj-cpp version(s): current master (e.g. 1.12-42-geca8f5f8)
  • tested on Ubuntu 20.10
  • Cmake flag TESTS_COMPATIBILITY is set

Please provide a reproduction of the bug:

cd build
cmake .. -DTESTS_COMPATIBILITY=ON -DCPACK_GENERATOR="DEB"
make package

How often bug is revealed:

always

Actual behavior:

Generated deb package (and probably rpm as well) contains the compatibility tests' sources and hence the old versions of libpmemobj-cpp

Expected behavior:

We should at least print a warning in CMake (with info is not recommended) or just test compatibility in different way (e.g. like in pmemkv)

lukaszstolarczuk avatar Mar 15 '21 12:03 lukaszstolarczuk