ConstructiveGeometry.jl icon indicating copy to clipboard operation
ConstructiveGeometry.jl copied to clipboard

Kwargs warning on stl export

Open pekpuglia opened this issue 3 years ago • 3 comments
trafficstars

The ConstructiveGeometry.stl function generates the following warning when used:

┌ Warning: use values(kwargs) and keys(kwargs) instead of kwargs.data and kwargs.itr │ caller = _ at ConstructiveGeometry.jl:221 [inlined] └ @ Core ~/.julia/packages/ConstructiveGeometry/on6NG/src/ConstructiveGeometry.jl:221 Minimal reproducible example in the REPL:

julia> using ConstructiveGeometry julia> c = cube(1) Cube julia> ConstructiveGeometry.stl("cube.stl", c)

I believe this is a simple matter of updating the way the kwargs Dict is used; i could not, however, find anything kwargs-related close to line 221, as specified in the message.

pekpuglia avatar Aug 17 '22 19:08 pekpuglia

I could not reproduce this — moreover, in the latest version, there is no stl() function. (It has been replaced by save()). Are you sure you have an up-to-date version?

plut avatar Aug 18 '22 16:08 plut

Well, my package had version number 0.2.0, the same as that in Project.toml in the repo. I tried ]update Constructivegeometry, to no success, reinstalling the package, uninstalling and garbage-collecting and reinstalling, also to no success. Maybe if the minor version number was incremented, Julia would recognize there is a new version to be installed. I could manually delete the .julia folder, or some subfolder, but I have lots of environments and would rather not mess with them.

Is incrementing the minor version number something you could try?

pekpuglia avatar Aug 18 '22 23:08 pekpuglia

This is certainly something I will try (once I feel the code has stabilized enough to at least compile the examples in the docs)

plut avatar Aug 19 '22 07:08 plut