plotly.py icon indicating copy to clipboard operation
plotly.py copied to clipboard

Update plotly.js to v2.33.0 + add docs

Open LiamConnors opened this issue 1 year ago • 2 comments
trafficstars

https://github.com/plotly/plotly.py/issues/4629

Documentation PR

  • [x] I've seen the doc/README.md file
  • [x] This change runs in the current version of Plotly on PyPI and targets the doc-prod branch OR it targets the master branch
  • [x] If this PR modifies the first example in a page or adds a new one, it is a px example if at all possible
  • [x] Every new/modified example has a descriptive title and motivating sentence or paragraph
  • [x] Every new/modified example is independently runnable
  • [x] Every new/modified example is optimized for short line count and focuses on the Plotly/visualization-related aspects of the example rather than the computation required to produce the data being visualized
  • [x] Meaningful/relatable datasets are used for all new examples instead of randomly-generated data where possible
  • [x] The random seed is set if using randomly-generated data in new/modified examples
  • [x] New/modified remote datasets are loaded from https://plotly.github.io/datasets and added to https://github.com/plotly/datasets
  • [x] Large computations are avoided in the new/modified examples in favour of loading remote datasets that represent the output of such computations
  • [x] Imports are plotly.graph_objects as go / plotly.express as px / plotly.io as pio
  • [x] Data frames are always called df
  • [x] fig = <something> call is high up in each new/modified example (either px.<something> or make_subplots or go.Figure)
  • [x] Liberal use is made of fig.add_* and fig.update_* rather than go.Figure(data=..., layout=...) in every new/modified example
  • [x] Specific adders and updaters like fig.add_shape and fig.update_xaxes are used instead of big fig.update_layout calls in every new/modified example
  • [x] fig.show() is at the end of each new/modified example
  • [x] plotly.plot() and plotly.iplot() are not used in any new/modified example
  • [x] Hex codes for colors are not used in any new/modified example in favour of these nice ones

Code PR

  • [ ] I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • [ ] I have added tests (if submitting a new feature or correcting a bug) or modified existing tests.
  • [ ] For a new feature, I have added documentation examples in an existing or new tutorial notebook (please see the doc checklist as well).
  • [ ] I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • [ ] For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

-->

LiamConnors avatar Jun 05 '24 16:06 LiamConnors

Thanks for the PR. @LiamConnors

Have you included this code change?https://github.com/plotly/plotly.py/commit/f1522cddfb06b1c4c6b7640ffba0513d86bf0161

archmoj avatar Jun 12 '24 20:06 archmoj

Thanks for the PR. @LiamConnors

Have you included this code change?f1522cd

Not yet. I'll include it after you merge your PR

LiamConnors avatar Jun 13 '24 16:06 LiamConnors

@emilykl @archmoj this is ready for review

LiamConnors avatar Jul 18 '24 14:07 LiamConnors

@LiamConnors Please also add an example for this PR: https://github.com/plotly/plotly.js/pull/7043. Thank you!

archmoj avatar Jul 18 '24 14:07 archmoj