plotly.js icon indicating copy to clipboard operation
plotly.js copied to clipboard

Fix rendering of WebGL traces on latest `Chrome-128` and `Edge-128` browsers

Open archmoj opened this issue 1 year ago • 1 comments
trafficstars

Fixes #7130.

@plotly/plotly_js cc: @birkskyum

archmoj avatar Aug 26 '24 23:08 archmoj

@alexcjohnson In respect to you comments I improved the handling of NaNs in parcoords constraintrange in 890ccfd.

In the case of stackgl these NaN conditions appear to occur for the 3D model matrix when the trace has empty arrays e.g.

Plotly.newPlot(gd, [{
    x: [],
    y: [],
    z: [],
    type: 'scatter3d'
}])

Or when they are turned off:

Plotly.newPlot(gd, [{
    visible: 'legendonly',
    x: [1],
    y: [2],
    z: [3],
    type: 'scatter3d'
}])

Whereas other applications namely ArcGIS also encountered this exact issue: https://community.esri.com/t5/arcgis-online-questions/map-error-in-new-chrome-update-128-0-6613-85/td-p/1525829 I still think this could/should be considered a Chrome regression which hopefully be fixed in future versions.

I hope this temporary fix is good enough to be included in the upcoming minor to bring back these traces.

archmoj avatar Aug 28 '24 19:08 archmoj

Good news: I found this bug as labeled P1 on chromium.org. See https://issues.chromium.org/issues/361823993

archmoj avatar Aug 28 '24 19:08 archmoj

@alexcjohnson @gvwilson With the revert updates in https://issues.chromium.org/issues/361823993 we may be able to close this PR. But I am still not sure how they are going to update the latest stable version. Let's wait until tomorrow.

archmoj avatar Aug 28 '24 19:08 archmoj

15 min ago - some people says things are working. Is there maybe a patch out already?

Screenshot 2024-08-28 at 21 46 58

My browser just now updated from: 128.0.6613.85 to 128.0.6613.114

birkskyum avatar Aug 28 '24 19:08 birkskyum

This is now fixed by Chromium 128.0.6613.113: https://chromium.googlesource.com/chromium/src/+/refs/tags/128.0.6613.113

I was able to update my Chrome. Closing.

archmoj avatar Aug 28 '24 20:08 archmoj

:+1:

gvwilson avatar Aug 28 '24 20:08 gvwilson