plotly.js icon indicating copy to clipboard operation
plotly.js copied to clipboard

Published 20 hours ago • verified publisher icon plotly

add deprecation warning for mapbox traces and mapbox subplot

Open archmoj opened this issue 1 year ago • 5 comments

With the introduction of scattermap, choroplethmap and densitymap as well as map subplots in #7060 this PR adds deprecation warnings to the description of scattermapbox, choroplethmaboxp and densitymapbox as well as mapbox subplots.

@plotly/plotly_js

archmoj avatar Aug 12 '24 16:08 archmoj

Previous deprecation warning example for reference: https://github.com/plotly/plotly.js/pull/5447

ndrezn avatar Aug 13 '24 15:08 ndrezn

It doesn't look like these deprecations will appear in the console if these traces are used... is that correct? I would expect a console warning

A warning is now added in the console when using a mapbox subplot.

archmoj avatar Aug 13 '24 16:08 archmoj

@emilykl Can I have your review on this PR please?

archmoj avatar Aug 13 '24 19:08 archmoj

@archmoj @ndrezn I would suggest changing the wording of the first sentence to

{trace name} trace is deprecated and will be removed in the next major release.

to give a sense of urgency.

emilykl avatar Aug 13 '24 19:08 emilykl

@ndrezn Would you please take over this PR?

archmoj avatar Aug 26 '24 13:08 archmoj

@archmoj , I've added the link where the JS migration guide will live (it is not live yet). I believe that plot-schema.json is autogenerated, I haven't run the build locally before -- could you regenerate this and add to the PR? I think then this PR is good to merge! 🥳

ndrezn avatar Aug 29 '24 14:08 ndrezn