plotly.js icon indicating copy to clipboard operation
plotly.js copied to clipboard

Fix: react to config changes

Open archmoj opened this issue 2 years ago • 3 comments
trafficstars

Fixes #6394.

@plotly/plotly_js

archmoj avatar Dec 14 '22 16:12 archmoj

Nice! Maybe then just a test like this one but for cartesian?

https://github.com/plotly/plotly.js/blob/897fb0a35a64ed0c914075b9dad141ffe008a3f0/test/jasmine/tests/plot_api_react_test.js#L439

alexcjohnson avatar Dec 14 '22 19:12 alexcjohnson

@alexcjohnson I don't recall what noCIdep was about. ¯\_(ツ)_/¯ After the changes proposed in this PR, it looks like we need to adjust the cartesian test right above the line you mentioned.

archmoj avatar Dec 21 '22 23:12 archmoj

@noCIdep came in here: https://github.com/plotly/plotly.js/commit/623146f91c

    // Although not recommended, some tests "depend" on other
    // tests to pass (e.g. the Plotly.react tests check that
    // all available traces and transforms are tested). Tag these
    // with @noCIdep, so that
    // - $ npm run test-jasmine -- tags=noCI,noCIdep
    // can pass.

So looks like on CI it's ignored, but it marks tests that need to run so the noCI tests succeed. Quite possibly obsolete by now, you could try running just npm run test-jasmine -- tags=noCI and see if it works?

And good call, I somehow hadn't noticed the cartesian test right above that 😅 But that test was already passing, right? So what can we add to that test that would have broken before this change but now works correctly?

alexcjohnson avatar Dec 22 '22 01:12 alexcjohnson

Reworked in #7475. Closing.

archmoj avatar Jul 17 '25 21:07 archmoj