plotly.js
plotly.js copied to clipboard
Support hovertemplate on hoveron: fills
Scatter trace currently doesn't hovertemplate on hoveron: fills. Change this to allow hovertemplate on fills when mode=='lines'
Looking good to me.
@fredricj could you please add a test here to lock the behavior?
Also please create draftlogs/6121_add.md file as described here.
Thank you!
@fredricj Are you interested in completing this PR?
We are using this feature on our site so getting it in would be great. I did for some reason miss the additional comments you made, but there is also some other issue I discovered when creating tests which I didn't have time to resolve. Right now I don't remember what so I will need to revisit the changes again and see what it was.
@fredricj FYI - I added this PR to our v2.35.0 milestone. Let's try to make it to the finish line.
Please fetch upstream/master and merge it into this branch to have the latest tests updates.
Thank you!
I think I have completed all the tasks for this PR now.
Looking back at how we use it, I wonder if it makes sense to implement hovertemplate for mode=lines. Unless I'm mistaken you can only have one line/polygon per trace, and the text generated from hovertemplate would then be the same wherever you hover in the areas filled and you could then use text/hovertext instead. It still might make sense to include it to get access to the trace data, but I'm not sure on this. The reason we implemented this on our side is (likely) due to the fact we couldnt get hovertext to work. Testing now it seems the "text" option works while "hovertext" does not, which I assume is a bug.
@marthacryan please have a look at this one when you have time
@camdecoster related to stuff you're currently working on?