plotly.js icon indicating copy to clipboard operation
plotly.js copied to clipboard

Published 20 hours ago • verified publisher icon plotly

Added `concentration` and small fixes

Open ggbaro opened this issue 5 years ago • 2 comments
trafficstars

Thanks for your interest in plotly.js!

Translations:

  • Make a PR directly to the main repository
  • Please @ mention a few other speakers of this language who can help review your translations. @Domino987
  • If you've omitted any keys from dist/translation_keys.txt - which means they will fall back on the US English text - just make a short comment about why in the PR description: the English text works fine in your language, or you would like someone else to help translating those, or whatever the reason.
  • You should only update files in lib/locales/, not those in dist/

Features, Bug fixes, and others:

Developers are strongly encouraged to first make a PR to their own plotly.js fork and ask one of the maintainers to review the modifications there. Once the pull request is deemed satisfactory, the developer will be asked to make a pull request to the main plotly.js repo and may be asked to squash some commits before doing so.

Before opening a pull request, developer should:

  • git rebase their local branch off the latest master,
  • make sure to not git add the dist/ folder (the dist/ is updated only on version bumps),
  • make sure to commit changes to the package-lock.json file (if any),
  • write an overview of what the PR attempts to do,
  • select the Allow edits from maintainers option (see this article for more details).

Note that it is forbidden to force push (i.e. git push -f) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please git merge master into your PR branch instead of git rebase master.

ggbaro avatar Dec 16 '19 10:12 ggbaro

Hi @ggbaro - thanks very much for the PR!

We'll need the approval from another native speaker before merging.

etpinard avatar Dec 16 '19 14:12 etpinard

This pull request has been sitting for a while, so I would like to close it as part of our effort to tidy up our public repositories. I've assigned it to myself to keep track of it; I'll wait until 2024-06-17 for someone to say it's still relevant and they'll to take it on, and otherwise I will close it then. Thanks - @gvwilson

gvwilson avatar Jun 10 '24 17:06 gvwilson

:100: :pray: Many thanks @ggbaro, @gvwilson and "the community member" :heart:

archmoj avatar Mar 31 '25 03:03 archmoj