Boolean attributes in button: disabled

[Akronix]

trafficstars

Hello.

I'm trying to use the disabled attribute in the button element.

Firstly, I've noticed that its type is String instead of Boolean. Secondly, I've trying to set the prop disabled='disabled', but it does not work; and it is still enabled.

Other props of button with expected similar behaviour (boolean props) are: autoFocus, contentEditable, draggable, hidden, spellCheck, etc.

[Akronix]

I finally got it done using the disabled attribute with a string as it is currently in the upstream repo.

Nevertheless, I was taking a look on how to change the PropTypes of html attributes, but I didn't find the way to do it. I guess that changing it directly in Button.react.js isn't the right way.

[radekwlsk]

Have you tried setting it to simply True? I am doing that with html.Button for a long time and never had an issue with html.Button("I am a disabled button", disabled=True).

[Akronix]

Hmm I just checked and it does work! But the prop for disabled in the component is still Boolean :thinking: