dash-daq icon indicating copy to clipboard operation
dash-daq copied to clipboard

Provide a ThemeProvider instead of a DarkThemeProvider

Open Bachibouzouk opened this issue 7 years ago • 2 comments

I find the DarkThemeProvider name misleading as it is possible to get a light theme by setting the attribute of DarkThemeProvider theme['dark'] to False.

IMHO, it would be useful to have a ThemeProvider which could also provide a "greyed out" theme, for when components are disabled for example :)

This would make the switch from light, dark or grey out easy using a callback on a theme['name'] attribute for example

Bachibouzouk avatar Jul 04 '18 13:07 Bachibouzouk

Wanted to add that when the theme is changed, the current state of the app is reset. See this example: https://dash-daq-stepper-motor.herokuapp.com/

try changing a slider value, then change the theme; it will reset.

xhluca avatar Jul 05 '18 17:07 xhluca

The DarkThemeProvider doesn't have an id, so one technically cannot write a callback with it

Bachibouzouk avatar Jul 10 '18 11:07 Bachibouzouk