refined-hacker-news
refined-hacker-news copied to clipboard
plibither8
Feature request: configurable keybindings
This can be done similarly to https://github.com/infokiller/web-search-navigator by adding an options page and storing the options in browser.sync.
Happy to send a PR if you are open to merging.
Related HN comment: https://news.ycombinator.com/item?id=20189188
Thanks!
Hi! This seems like a good idea :)
By adding a separate options page that is different from the popup page, we will have two places where one sets the extension settings, which doesn't look too good. All settings/options regarding the extension should be at one place only - either the popup or the options page.
Could you explain a bit more on how you will implement this in the code? Or better still, if you could create the PR, I can look at the code then and we can discuss about it.
Nevertheless, this is a nice enhancement which I'll be happy to look into.
Cheers!
Oh I wasn't aware of the pop up page, yes it definitely makes sense to add the customizations to that page. Great, will send a PR soon.